lkml.org 
[lkml]   [2015]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] netfilter: ipset: fix boolreturn.cocci warnings
On Wed, 11 Feb 2015, kbuild test robot wrote:

> net/netfilter/xt_set.c:196:9-10: WARNING: return of 0/1 in function 'set_match_v3' with return type bool
> net/netfilter/xt_set.c:242:9-10: WARNING: return of 0/1 in function 'set_match_v4' with return type bool
>
> Return statements in functions returning bool should use
> true/false instead of 1/0.
> Generated by: scripts/coccinelle/misc/boolreturn.cocci
>
> CC: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>

Patch is applied, thanks.

Best regards,
Jozsef

> ---
>
> xt_set.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- a/net/netfilter/xt_set.c
> +++ b/net/netfilter/xt_set.c
> @@ -193,7 +193,7 @@ set_match_v3(const struct sk_buff *skb,
> return ret;
>
> if (!match_counter0(opt.ext.packets, &info->packets))
> - return 0;
> + return false;
> return match_counter0(opt.ext.bytes, &info->bytes);
> }
>
> @@ -239,7 +239,7 @@ set_match_v4(const struct sk_buff *skb,
> return ret;
>
> if (!match_counter(opt.ext.packets, &info->packets))
> - return 0;
> + return false;
> return match_counter(opt.ext.bytes, &info->bytes);
> }
>
> --
> To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>

-
E-mail : kadlec@blackhole.kfki.hu, kadlecsik.jozsef@wigner.mta.hu
PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt
Address : Wigner Research Centre for Physics, Hungarian Academy of Sciences
H-1525 Budapest 114, POB. 49, Hungary


\
 
 \ /
  Last update: 2015-03-11 20:21    [W:0.091 / U:2.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site