lkml.org 
[lkml]   [2015]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH 2/2] xen-pciback: also support disabling of bus-mastering and memory-write-invalidate
On Wed, Mar 11, 2015 at 01:52:00PM +0000, Jan Beulich wrote:
> It's not clear to me why only the enabling operation got handled so
> far.

Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> drivers/xen/xen-pciback/conf_space_header.c | 16 +++++++++++++++-
> 1 file changed, 15 insertions(+), 1 deletion(-)
>
> --- 4.0-rc3-xen-pciback.orig/drivers/xen/xen-pciback/conf_space_header.c
> +++ 4.0-rc3-xen-pciback/drivers/xen/xen-pciback/conf_space_header.c
> @@ -88,9 +88,15 @@ static int command_write(struct pci_dev
> printk(KERN_DEBUG DRV_NAME ": %s: set bus master\n",
> pci_name(dev));
> pci_set_master(dev);
> + } else if (dev->is_busmaster && !is_master_cmd(value)) {
> + if (unlikely(verbose_request))
> + printk(KERN_DEBUG DRV_NAME ": %s: clear bus master\n",
> + pci_name(dev));
> + pci_clear_master(dev);
> }
>
> - if (value & PCI_COMMAND_INVALIDATE) {
> + if (!(cmd->val & PCI_COMMAND_INVALIDATE) &&
> + (value & PCI_COMMAND_INVALIDATE)) {
> if (unlikely(verbose_request))
> printk(KERN_DEBUG
> DRV_NAME ": %s: enable memory-write-invalidate\n",
> @@ -101,6 +107,13 @@ static int command_write(struct pci_dev
> pci_name(dev), err);
> value &= ~PCI_COMMAND_INVALIDATE;
> }
> + } else if ((cmd->val & PCI_COMMAND_INVALIDATE) &&
> + !(value & PCI_COMMAND_INVALIDATE)) {
> + if (unlikely(verbose_request))
> + printk(KERN_DEBUG
> + DRV_NAME ": %s: disable memory-write-invalidate\n",
> + pci_name(dev));
> + pci_clear_mwi(dev);
> }
>
> cmd->val = value;
>
>
>


\
 
 \ /
  Last update: 2015-03-11 16:01    [W:0.067 / U:0.764 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site