lkml.org 
[lkml]   [2015]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] virtio_rpmsg: set DRIVER_OK before using device
On Mon, Mar 9, 2015 at 10:41 AM, Michael S. Tsirkin <mst@redhat.com> wrote:
> On Sat, Mar 07, 2015 at 08:06:56PM +0100, Michael S. Tsirkin wrote:
>> virtio spec requires that all drivers set DRIVER_OK
>> before using devices. While rpmsg isn't yet
>> included in the virtio 1 spec, previous spec versions
>> also required this.
>>
>> virtio rpmsg violates this rule: is calls kick
>> before setting DRIVER_OK.
>>
>> The fix isn't trivial since simply calling virtio_device_ready earlier
>> would mean we might get an interrupt in parallel with adding buffers.
>>
>> Instead, split kick out to prepare+notify calls. prepare before
>> virtio_device_ready - when we know we won't get interrupts. notify right
>> afterwards.
>>
>> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>> ---
>
> Ohad, can you review and ack pls?

Sure,

Acked-by: Ohad Ben-Cohen <ohad@wizery.com>


\
 
 \ /
  Last update: 2015-03-11 14:01    [W:1.384 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site