Messages in this thread | | | Date | Wed, 11 Mar 2015 12:00:53 +0100 | From | Javier Martinez Canillas <> | Subject | Re: [PATCH 1/1] regulator: Only enable disabled regulators on resume |
| |
On 03/11/2015 11:57 AM, Mark Brown wrote: > On Mon, Mar 09, 2015 at 08:40:20AM +0100, Javier Martinez Canillas wrote: >> On 03/08/2015 08:38 PM, Mark Brown wrote: >> > You mean _do_enable(), not _enable() here. It's not really a leftover > >> No, I meant _enable() here. What I said is that _enable() is checking >> if -EINVAL was returned by _is_enabled(): > > Then we have an abstraction problem if we're trying to do things in > plain _enable() - _do_enable() is supposed to be hiding all this stuff. >
Agreed.
Best regards, Javier
| |