Messages in this thread | | | Date | Tue, 10 Mar 2015 08:37:04 -0700 | From | Andi Kleen <> | Subject | Re: [PATCH 1/4] perf, tools: Output running time and run/enabled ratio in CSV mode |
| |
> Why not handle both cases here? > > static void print_running(u64 run, u64 ena) > { > if (csv_output) > fprintf(output, ...); > else if (run != ena) > fprintf(output, ...); > }
print_running has 6 callers. run != ena is only needed for two of them. So I don't think it makes sense to do.
-Andi
| |