Messages in this thread | | | Date | Tue, 10 Mar 2015 08:42:20 -0400 | From | Tejun Heo <> | Subject | Re: [RFC] lib/vsprintf.c: Even faster decimal conversion |
| |
Hello,
On Tue, Mar 10, 2015 at 11:47:47AM +0100, Rasmus Villemoes wrote: > I can't explain why num_to_str apparently becomes slightly slower (the > patch essentially didn't touch it), but the put_dec_ helpers in any case > make up for that.
Unrelated code changes affecting performance in seemingly random way isn't too uncommon. A lot of it arises from cacheline behaviors. The effect is sometimes surprisingly big.
Generally looks pretty good to me. Andrew, can you please pick this patch up?
Thanks.
-- tejun
| |