lkml.org 
[lkml]   [2015]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/8] x86, kaslr: get kaslr_enabled back correctly

    (Cc:-ed Jiri and Kees as well.)

    * Borislav Petkov <bp@suse.de> wrote:

    > On Sat, Feb 28, 2015 at 06:40:39PM -0800, Yinghai Lu wrote:
    > >
    > > oh, no. the offending commit already got into linus tree.
    >
    > We're working on it, follow this thread:
    >
    > http://lkml.kernel.org/r/1424929021.10337.24.camel@intel.com

    I think that's a different bug.

    parse_kaslr_setup() is simply bogus, it does:

    kaslr_enabled = (bool)(pa_data + sizeof(struct setup_data));

    which makes no sense whatsoever: it randomly enables (or disables,
    depending on the physical address of the setup page) KASLR when it
    meets a SETUP_KASLR record.

    So I'm inclined to apply Yinghai's fix, with a better changelog that
    explains what happened ...

    Agreed?

    Thanks,

    Ingo


    \
     
     \ /
      Last update: 2015-03-01 17:01    [W:5.430 / U:0.628 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site