Messages in this thread | | | Date | Sun, 1 Mar 2015 22:45:27 -0300 | Subject | Re: [PATCH v2] staging: lustre: fld_request.c: Remove else after return. | From | Alberto Pires de Oliveira Neto <> |
| |
that's true.
I think it's ok now.
On Sun, Mar 1, 2015 at 10:30 PM, Greg KH <gregkh@linuxfoundation.org> wrote: > On Sat, Feb 28, 2015 at 01:37:23PM -0300, Alberto Pires de Oliveira Neto wrote: >> This patch fixes checkpatch.pl warning. >> WARNING: else is not generally useful after a break or return >> >> Signed-off-by: Alberto Pires de Oliveira Neto <mrpenguin2005@gmail.com> >> --- >> drivers/staging/lustre/lustre/fld/fld_request.c | 7 +++---- >> 1 file changed, 3 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/staging/lustre/lustre/fld/fld_request.c b/drivers/staging/lustre/lustre/fld/fld_request.c >> index b8d17e1..0b00301 100644 >> --- a/drivers/staging/lustre/lustre/fld/fld_request.c >> +++ b/drivers/staging/lustre/lustre/fld/fld_request.c >> @@ -217,10 +217,9 @@ int fld_client_add_target(struct lu_client_fld *fld, >> CERROR("%s: Attempt to add target %s (idx %llu) on fly - skip it\n", >> fld->lcf_name, name, tar->ft_idx); >> return 0; >> - } else { >> - CDEBUG(D_INFO, "%s: Adding target %s (idx %llu)\n", >> - fld->lcf_name, name, tar->ft_idx); >> - } >> + } >> + CDEBUG(D_INFO, "%s: Adding target %s (idx %llu)\n", >> + fld->lcf_name, name, tar->ft_idx); >> >> OBD_ALLOC_PTR(target); >> if (target == NULL) > > Never add new checkpatch errors when trying to fix checkpatch errors, as > you will never end up removing them... > > Please fix and resend.
| |