lkml.org 
[lkml]   [2015]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v3 2/4] scsi: ufs: add debugfs for ufs
    From
    >> +#define UFSHCD_UPDATE_TAG_STATS(hba, tag)
    >> +#define UFSHCD_UPDATE_TAG_STATS_COMPLETION(hba, cmd)
    >> +#define UFSHCD_UPDATE_ERROR_STATS(hba, type)
    >> +
    >> +#endif
    >
    > Is there any reason that these are defined as macros instead of
    > static functions?

    No special reason that I'm aware of. I will convert those to functions.


    >> out_remove_scsi_host:
    >> @@ -5769,6 +5969,7 @@ exit_gating:
    >> out_disable:
    >> hba->is_irq_enabled = false;
    >> scsi_host_put(host);
    >> + ufsdbg_remove_debugfs(hba);
    >> ufshcd_hba_exit(hba);
    >> out_error:
    >> return err;
    >
    > This ufsdbg_remove_debugfs() call on error path of ufshcd_init() is
    > unnecessary. Because ufsdbg_add_debugfs() is called at the last of
    > ufshcd_init() and can't fail.
    >

    I will fix this in the next patchset.


    --
    Qualcomm Israel, on behalf of Qualcomm Innovation Center, Inc.
    The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
    a Linux Foundation Collaborative Project



    \
     
     \ /
      Last update: 2015-03-01 09:41    [W:2.823 / U:0.136 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site