Messages in this thread | | | Subject | Re: [PATCH v3] scripts: checkpatch.pl: add 2 new checks on memset | From | Joe Perches <> | Date | Sun, 01 Mar 2015 15:45:49 -0800 |
| |
On Mon, 2015-03-02 at 01:38 +0200, Aya Mahfouz wrote: > On Sun, Mar 01, 2015 at 02:13:21PM -0800, Joe Perches wrote: > > On Sun, 2015-03-01 at 23:43 +0200, Aya Mahfouz wrote: > > > calls > > > Reply-To: > > > > > > Add 2 new checks on memset calls in the file checkpatch.pl as follows: > > > > Hi again Aya > > > > The initial 3 lines here aren't necessary. > > > > I think it'd be a better subject line with something like > > "checkpatch: prefer eth_<foo>_addr over memset(,,ETH_ALEN)" > > > ok, should I resend it as a fresh patch or send the patch with a new > subject line and state that it is v4?
Send V4 with new subject and cc Andrew.
> > Please cc Andrew Morton <akpm@linux-foundation.org> > > And please also don't add Signed-off-by: lines for > > anyone other than yourself. > > > ok, I will cc Andrew. As for your tag, I couldn't take credit > for the regex that I did not write. Will not do it in the future again > unless the other side agrees to it.
No worries from me.
"Suggested-by:" or "Portions-by:" or just some text with "credit to: <name>" for the suggestions, etc
cheers, Joe
| |