Messages in this thread | | | Date | Sun, 01 Mar 2015 20:07:46 +0200 | From | Nikolai Kondrashov <> | Subject | Re: [PATCH v2 4/6] HID: uclogic: apply quirk NO_EMPTY_INPUT |
| |
On 02/26/2015 08:57 PM, Benjamin Tissoires wrote: > NO_EMPTY_INPUT is useful when MULTI_INPUT is set. It prevents to create > empty input nodes that user space does not know what to do with. > > It does not seem to be required at the moment, this is just a preventive > patch. This check is only made during the plug of the device, so it does > not hurt to have it. > > Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> > --- > > New in v2 > > drivers/hid/hid-uclogic.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/hid/hid-uclogic.c b/drivers/hid/hid-uclogic.c > index 90e2612..ada8a94 100644 > --- a/drivers/hid/hid-uclogic.c > +++ b/drivers/hid/hid-uclogic.c > @@ -868,6 +868,7 @@ static int uclogic_probe(struct hid_device *hdev, > * than the pen, so use QUIRK_MULTI_INPUT for all tablets. > */ > hdev->quirks |= HID_QUIRK_MULTI_INPUT; > + hdev->quirks |= HID_QUIRK_NO_EMPTY_INPUT; > > /* Allocate and assign driver data */ > drvdata = devm_kzalloc(&hdev->dev, sizeof(*drvdata), GFP_KERNEL);
This seems safe and fine as a preventive.
Reviewed-by: Nikolai Kondrashov <spbnick@gmail.com>
Nick
| |