Messages in this thread | | | Date | Mon, 9 Feb 2015 21:59:09 -0700 | Subject | Re: [PATCH v2] toshiba_acpi: Make toshiba_eco_mode_available more robust | From | Azael Avalos <> |
| |
Hi Darren,
2015-02-09 21:22 GMT-07:00 Darren Hart <dvhart@infradead.org>: > On Mon, Feb 09, 2015 at 08:55:02PM -0700, Azael Avalos wrote: >> Some Toshiba laptops do not come with the ECO led installed, however, >> the driver is registering support for it when it should not. >> >> This patch makes the toshiba_eco_mode_available function more robust >> in detecting ECO led capabilities, not registering the led on laptops >> that do not support it and registering the led when it really does. >> >> The ECO led function now returns 0x8e00 (Not Installed) by querying >> with in[3] = 0, whenever theres no physical LED installed, and >> returning 0x8300 (Input Data Error) when it is, however, there are >> some BIOSes that have stub function calls not returning anything and >> and the LED device was being registered too, hence the change of the >> default return value from 1 to 0. >> >> Signed-off-by: Azael Avalos <coproscefalo@gmail.com> > > Careful with whitespace errors caught by checkpatch. Fixed that and corrected a minor > grammatical issue in the comment block - since I was late in reviewing ;-)
Apologies for that, between my bit of dyslexia (I tend to switch numbers and letters) and my bad English...
Good thing I'm not working at a bank or stock exchange ;-)
> > Applied and queued, thanks. > > -- > Darren Hart > Intel Open Source Technology Center
Cheers Azael
-- -- El mundo apesta y vosotros apestais tambien --
| |