[lkml]   [2015]   [Feb]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v2] toshiba_acpi: Make toshiba_eco_mode_available more robust
On Mon, Feb 09, 2015 at 08:55:02PM -0700, Azael Avalos wrote:
> Some Toshiba laptops do not come with the ECO led installed, however,
> the driver is registering support for it when it should not.
> This patch makes the toshiba_eco_mode_available function more robust
> in detecting ECO led capabilities, not registering the led on laptops
> that do not support it and registering the led when it really does.
> The ECO led function now returns 0x8e00 (Not Installed) by querying
> with in[3] = 0, whenever theres no physical LED installed, and
> returning 0x8300 (Input Data Error) when it is, however, there are
> some BIOSes that have stub function calls not returning anything and
> and the LED device was being registered too, hence the change of the
> default return value from 1 to 0.
> Signed-off-by: Azael Avalos <>

Careful with whitespace errors caught by checkpatch. Fixed that and corrected a minor
grammatical issue in the comment block - since I was late in reviewing ;-)

Applied and queued, thanks.

Darren Hart
Intel Open Source Technology Center

 \ /
  Last update: 2015-02-10 05:41    [W:0.034 / U:42.360 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site