Messages in this thread | | | Date | Tue, 10 Feb 2015 05:34:08 +0800 | From | "<>" <> | Subject | Re: [PATCH v3] staging: lustre: fix coding style errors |
| |
On Mon, Feb 09, 2015 at 07:20:30PM +0200, Tal Shorer wrote: > Fix the following coding style errors in > drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c: > 1. initializing lnet_table_header (static pointer) to NULL > 2. missing spaces around '='
Those are two different things, and should be 2 different patches. Please split up and resend that way.
> There's a third coding style error in this file which I've chosen to > not fix for clarity's sake. It is: initializing min_watchdog_ratelimit > (static int) to 0
Please fix that too, it's not correct. Drop the comment there if you think that's confusing.
thanks,
greg k-h
| |