lkml.org 
[lkml]   [2015]   [Feb]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] staging: lustre: fix coding style errors in drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c
On Sun, Feb 08, 2015 at 07:57:01PM +0200, Tal Shorer wrote:
> Signed-off-by: Tal Shorer <tal.shorer@gmail.com>
> ---
> Decided not to #define the constants away because their addresses are
> used later in the file.

I don't understand what this means.

>

1) The subject is crap (which coding style issues are you fixing).
2) The subject is too long.
3) Don't put the whole path in the subject.
4) There is no patch description.

regards,
dan carpenter



\
 
 \ /
  Last update: 2015-02-09 08:41    [W:0.035 / U:8.628 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site