lkml.org 
[lkml]   [2015]   [Feb]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: gpio-pxa: getting GPIOs by devicetree phandle broken
> The issue with multiple gpiochips per of-node could be worked around as followed I believe, comments?
>
> diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c
> index 08261f2..43984ab 100644
> --- a/drivers/gpio/gpiolib-of.c
> +++ b/drivers/gpio/gpiolib-of.c
> @@ -47,11 +47,12 @@ static int of_gpiochip_find_and_xlate(struct gpio_chip *gc, void *data)
> ret = gc->of_xlate(gc, &gg_data->gpiospec, gg_data->flags);
> if (ret < 0) {
> /* We've found the gpio chip, but the translation failed.
> - * Return true to stop looking and return the translation
> - * error via out_gpio
> + * Store translation error in out_gpio.
> + * Return false to keep looking, as more than one GPIO chip
> + * could be registered per of-node.
> */
> gg_data->out_gpio = ERR_PTR(ret);
> - return true;
> + return false;
> }
>
> gg_data->out_gpio = gpiochip_get_desc(gc, ret);

As long as we're ok with multiple gpiochips per of-node, this would
work for me. It'll change the preference of which chip returns the
error in the case of multiple chips, but that's already undefined
behavior.


\
 
 \ /
  Last update: 2015-02-09 16:01    [W:0.110 / U:1.776 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site