lkml.org 
[lkml]   [2015]   [Feb]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 09/13] ARM: dts: mediatek: Enable clock support for Mediatek MT8135.
    On Mon, Feb 09, 2015 at 12:25:00PM +0100, Sascha Hauer wrote:
    > On Mon, Feb 09, 2015 at 10:51:34AM +0000, Russell King - ARM Linux wrote:
    > > On Mon, Feb 09, 2015 at 11:47:21AM +0100, Sascha Hauer wrote:
    > > > From: James Liao <jamesjj.liao@mediatek.com>
    > > >
    > > > This patch adds MT8135 clock controllers into device tree.
    > > > @@ -86,6 +87,18 @@
    > > > clock-frequency = <32000>;
    > > > #clock-cells = <0>;
    > > > };
    > > > +
    > > > + clk_null: clk_null {
    > > > + compatible = "fixed-clock";
    > > > + #clock-cells = <0>;
    > > > + clock-frequency = <0>;
    > > > + };
    > > > +
    > > > + clk26m: clk26m {
    > > > + compatible = "fixed-clock";
    > > > + #clock-cells = <0>;
    > > > + clock-frequency = <26000000>;
    > > > + };
    > >
    > > Is this supposed to be here?
    >
    > The clock support needs at least the clk26m clk. Do you think it should
    > be in another patch or not present at all?

    I didn't see anything which referenced either clk_null or clk26m in this
    patch. My main concern was that clk_null, but my concern grew when I
    found that clk26m wasn't referenced either.

    If the MT8135 needs it, shouldn't something in its description reference
    this clock?

    --
    FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
    according to speedtest.net.


    \
     
     \ /
      Last update: 2015-02-09 12:41    [W:5.571 / U:0.856 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site