lkml.org 
[lkml]   [2015]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: iio: resolver: ad2s1210: Change type in printf format string
On 27/01/15 22:22, Rickard Strandqvist wrote:
> Wrong type in printf format string, requires 'int'
> but the argument type is 'unsigned int'
>
> This was found using a static code analysis program called cppcheck
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Finally one I don't already have a fix in place for!
Applied to the togreg branch of iio.git.
Note this will first get pushed out as staging when I get a few minutes at
home (no sign of my plane yet that was meant to leave an hour ago...)
> ---
> drivers/staging/iio/resolver/ad2s1210.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/iio/resolver/ad2s1210.c b/drivers/staging/iio/resolver/ad2s1210.c
> index b4c14ba..a8ecf87 100644
> --- a/drivers/staging/iio/resolver/ad2s1210.c
> +++ b/drivers/staging/iio/resolver/ad2s1210.c
> @@ -198,7 +198,7 @@ static ssize_t ad2s1210_show_fclkin(struct device *dev,
> {
> struct ad2s1210_state *st = iio_priv(dev_to_iio_dev(dev));
>
> - return sprintf(buf, "%d\n", st->fclkin);
> + return sprintf(buf, "%u\n", st->fclkin);
> }
>
> static ssize_t ad2s1210_store_fclkin(struct device *dev,
> @@ -237,7 +237,7 @@ static ssize_t ad2s1210_show_fexcit(struct device *dev,
> {
> struct ad2s1210_state *st = iio_priv(dev_to_iio_dev(dev));
>
> - return sprintf(buf, "%d\n", st->fexcit);
> + return sprintf(buf, "%u\n", st->fexcit);
> }
>
> static ssize_t ad2s1210_store_fexcit(struct device *dev,
>



\
 
 \ /
  Last update: 2015-02-08 13:21    [W:0.044 / U:11.656 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site