lkml.org 
[lkml]   [2015]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: iio: trigger: iio-trig-periodic-rtc: Change type in printf format string
On 27/01/15 21:32, Rickard Strandqvist wrote:
> Wrong type in printf format string, requires 'unsigned int'
> but the argument type is 'int'
>
> This was found using a static code analysis program called cppcheck
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Whilst you have identified a bug, I think the better fix would be to take frequency unsigned.
It is always treated as such in the driver so they type should probably reflect this.

If you want to put together such a patch that would be great. If not I'll
get to it at some point (probably!)
> ---
> drivers/staging/iio/trigger/iio-trig-periodic-rtc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/trigger/iio-trig-periodic-rtc.c b/drivers/staging/iio/trigger/iio-trig-periodic-rtc.c
> index a24caf7..66d54a0 100644
> --- a/drivers/staging/iio/trigger/iio-trig-periodic-rtc.c
> +++ b/drivers/staging/iio/trigger/iio-trig-periodic-rtc.c
> @@ -52,7 +52,7 @@ static ssize_t iio_trig_periodic_read_freq(struct device *dev,
> struct iio_trigger *trig = to_iio_trigger(dev);
> struct iio_prtc_trigger_info *trig_info = iio_trigger_get_drvdata(trig);
>
> - return sprintf(buf, "%u\n", trig_info->frequency);
> + return sprintf(buf, "%d\n", trig_info->frequency);
> }
>
> static ssize_t iio_trig_periodic_write_freq(struct device *dev,
>



\
 
 \ /
  Last update: 2015-02-08 13:21    [W:0.045 / U:2.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site