lkml.org 
[lkml]   [2015]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] drivers: usb: storage: cypress_atacb.c: trivial checkpatch fixes
On 2/8/2015 1:42 AM, Bas Peters wrote:

> Fixes errors thrown by checkpatch over a space issue and the
> incorrect indentation of a switch statement.

> Signed-off-by: Bas Peters <baspeters93@gmail.com>
> ---
> drivers/usb/storage/cypress_atacb.c | 17 ++++++++---------
> 1 file changed, 8 insertions(+), 9 deletions(-)

> diff --git a/drivers/usb/storage/cypress_atacb.c b/drivers/usb/storage/cypress_atacb.c
> index 8514a2d..b3466d1 100644
> --- a/drivers/usb/storage/cypress_atacb.c
> +++ b/drivers/usb/storage/cypress_atacb.c
> @@ -96,13 +96,13 @@ static void cypress_atacb_passthrough(struct scsi_cmnd *srb, struct us_data *us)
> if (save_cmnd[1] >> 5) /* MULTIPLE_COUNT */
> goto invalid_fld;
> /* check protocol */
> - switch((save_cmnd[1] >> 1) & 0xf) {
> - case 3: /*no DATA */
> - case 4: /* PIO in */
> - case 5: /* PIO out */
> - break;
> - default:
> - goto invalid_fld;
> + switch ((save_cmnd[1] >> 1) & 0xf) {
> + case 3: /*no DATA */

Could also add space after /*, while at it.

> + case 4: /* PIO in */
> + case 5: /* PIO out */
> + break;
> + default:
> + goto invalid_fld;
> }
>
> /* first build the ATACB command */
[...]

WBR, Sergei



\
 
 \ /
  Last update: 2015-02-08 12:41    [W:0.067 / U:4.508 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site