[lkml]   [2015]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v4 2/5] sched_clock: Optimize cache line usage
On Sun, Feb 08, 2015 at 12:02:37PM +0000, Daniel Thompson wrote:
> Currently sched_clock(), a very hot code path, is not optimized to
> minimise its cache profile. In particular:
> 1. cd is not ____cacheline_aligned,
> 2. struct clock_data does not distinguish between hotpath and
> coldpath data, reducing locality of reference in the hotpath,
> 3. Some hotpath data is missing from struct clock_data and is marked
> __read_mostly (which more or less guarantees it will not share a
> cache line with cd).
> This patch corrects these problems by extracting all hotpath data
> into a separate structure and using ____cacheline_aligned to ensure
> the hotpath uses a single (64 byte) cache line.

Have you got any performance figures for this change, or is this just a
theoretical optimisation? It would be interesting to see what effect this
has on systems with 32-byte cachelines and also scenarios where there's
contention on the sequence counter.


 \ /
  Last update: 2015-02-09 02:41    [W:0.138 / U:5.644 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site