Messages in this thread | | | Date | Sat, 07 Feb 2015 18:23:42 +0100 | From | SF Markus Elfring <> | Subject | Re: [PATCH 2/4] SCSI-QLA4...: Less function calls in qla4xxx_is_session_exists() after error detection |
| |
> 1) People gloss over initializers without reading them.
I would find such a habit strange.
> You shouldn't put complicated code in initializers.
Does the affected memory allocation fall into such a category?
> 2) It means you have to put a line of separation between the allocation > and the NULL check, but they should be next to each other.
Would you like to extend the Linux coding style documentation?
Regards, Markus
| |