lkml.org 
[lkml]   [2015]   [Feb]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] SCSI-csiostor: Delete an unnecessary check before the function call "release_firmware"
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Fri, 6 Feb 2015 19:10:25 +0100

    The release_firmware() function tests whether its argument is NULL and then
    returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/scsi/csiostor/csio_hw.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/scsi/csiostor/csio_hw.c b/drivers/scsi/csiostor/csio_hw.c
    index 35c5f83..37fa8bf 100644
    --- a/drivers/scsi/csiostor/csio_hw.c
    +++ b/drivers/scsi/csiostor/csio_hw.c
    @@ -2117,8 +2117,7 @@ csio_hw_flash_fw(struct csio_hw *hw, int *reset)
    hw->fw_state, reset);

    /* Cleaning up */
    - if (fw != NULL)
    - release_firmware(fw);
    + release_firmware(fw);
    kfree(card_fw);
    return ret;
    }
    --
    2.2.2


    \
     
     \ /
      Last update: 2015-02-06 20:01    [W:4.020 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site