lkml.org 
[lkml]   [2015]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -tip/urgent 1/2] [BUGFIX]kprobes: set kprobes_all_disarmed earlier to enable re-optimization.
On Fri, 23 Jan 2015 15:42:24 +0900 Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> wrote:

> From: Wang Nan <wangnan0@huawei.com>
>
> In original code, the probed instruction doesn't get optimized after
>
> echo 0 > /sys/kernel/debug/kprobes/enabled
> echo 1 > /sys/kernel/debug/kprobes/enabled
>
> This is because original code checks kprobes_all_disarmed in
> optimize_kprobe(), but this flag is turned off after calling that
> function. Therefore, optimize_kprobe() will see
> kprobes_all_disarmed == true and doesn't do the optimization.
>
> This patch simply turns off kprobes_all_disarmed earlier to enable
> optimization.
>
> Signed-off-by: Wang Nan <wangnan0@huawei.com>
> Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>

You sent the patches, so this should have been "Signed-off-by:".
Documentation/SubmittingPatches section 12 has the details.

I have made that change to my copy of these two patches.



\
 
 \ /
  Last update: 2015-02-06 00:21    [W:0.071 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site