lkml.org 
[lkml]   [2015]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3] i2c: i2c-ocores: add common clock support
> +#ifdef CONFIG_HAVE_CLK
> + if (!IS_ERR(i2c->clk))
> + clk_disable_unprepare(i2c->clk);
> +#endif

Ehrm, you can leave out all the #ifdeffery :) The functions are all
empty in the !HAVE_CLK scenario. The only one which might be left is the
pointer in the struct. I'll leave it to you if you want to save the
bytes or the lines of code.

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2015-02-05 21:01    [W:0.330 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site