lkml.org 
[lkml]   [2015]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: use of opaque subject lines
On Thu, Feb 05, 2015 at 09:08:59AM -0800, Joe Perches wrote:
> On Thu, 2015-02-05 at 16:30 +0000, Al Viro wrote:
> > On Mon, Feb 02, 2015 at 08:13:10PM +0100, Andreas Ruprecht wrote:
> >
> > > On a serious note: I do understand what you're getting at, I don't take
> > > that personally (and I will send a v2 addressing the things above), but
> > > honestly, this kind of answer might just be a real turn-off for other
> > > people trying to get into kernel development...
> > >
> > > I don't want to start a whole new 'attitude in the kernel community'
> > > discussion, but I can't just let this go like that, sorry.
>
> Maybe YA checkpatch warning when patch subjects
> include either "checkpatch" or "sparse" would help?
>
> Something like:
> ---
> scripts/checkpatch.pl | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 3642b0d..b6bed59 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2170,6 +2170,13 @@ sub process {
> }
> }
>
> +# Check email subject for poor style
> + if ($in_header_lines &&
> + $line =~ /^Subject:.*\b(?:checkpatch|sparse)\b[^:]/i) {
> + WARN("EMAIL_SUBJECT",
> + "A patch subject line should describe the change not the tool that found it\n" . $herecurr);
> + }
> +
> # Check for old stable address
> if ($line =~ /^\s*cc:\s*.*<?\bstable\@kernel\.org\b>?.*$/i) {
> ERROR("STABLE_ADDRESS",
>


Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>


\
 
 \ /
  Last update: 2015-02-05 19:21    [W:0.078 / U:0.548 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site