Messages in this thread | | | From | "Lad, Prabhakar" <> | Date | Thu, 5 Feb 2015 16:22:39 +0000 | Subject | Re: [PATCH] net/macb: fix sparse warning |
| |
On Thu, Feb 5, 2015 at 4:06 PM, Nicolas Ferre <nicolas.ferre@atmel.com> wrote: > Le 05/02/2015 16:40, Lad Prabhakar a écrit : >> From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com> >> >> this patch fixes following sparse warning: >> >> macb.c:2038:26: warning: symbol 'gem_ethtool_ops' was not declared. Should it be static? > > Well, actually this function doesn't need to be exported and indeed > should be marked as static. > > I'm not against this patch, but removing the export macro and making it > as static should do the trick even better. > Done!
[1] https://patchwork.kernel.org/patch/5785511/
Cheers, --Prabhakar Lad
| |