lkml.org 
[lkml]   [2015]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] USB: whci-hcd: Delete an unnecessary check before the function call "usb_put_hcd"
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Thu, 5 Feb 2015 16:54:12 +0100

    The usb_put_hcd() function tests whether its argument is NULL and then
    returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/usb/host/whci/hcd.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/usb/host/whci/hcd.c b/drivers/usb/host/whci/hcd.c
    index d7b363a..43626c4 100644
    --- a/drivers/usb/host/whci/hcd.c
    +++ b/drivers/usb/host/whci/hcd.c
    @@ -313,8 +313,7 @@ error_wusbhc_create:
    uwb_rc_put(wusbhc->uwb_rc);
    error:
    whc_clean_up(whc);
    - if (usb_hcd)
    - usb_put_hcd(usb_hcd);
    + usb_put_hcd(usb_hcd);
    return ret;
    }

    --
    2.2.2


    \
     
     \ /
      Last update: 2015-02-05 17:21    [W:4.427 / U:0.252 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site