lkml.org 
[lkml]   [2015]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] USB: appledisplay: Deletion of a check before backlight_device_unregister()
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Thu, 5 Feb 2015 16:07:43 +0100

    The backlight_device_unregister() function tests whether its argument is NULL
    and then returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/usb/misc/appledisplay.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/usb/misc/appledisplay.c b/drivers/usb/misc/appledisplay.c
    index b3d245e..a0a3827 100644
    --- a/drivers/usb/misc/appledisplay.c
    +++ b/drivers/usb/misc/appledisplay.c
    @@ -329,7 +329,7 @@ error:
    pdata->urbdata, pdata->urb->transfer_dma);
    usb_free_urb(pdata->urb);
    }
    - if (pdata->bd && !IS_ERR(pdata->bd))
    + if (!IS_ERR(pdata->bd))
    backlight_device_unregister(pdata->bd);
    kfree(pdata->msgdata);
    }
    --
    2.2.2


    \
     
     \ /
      Last update: 2015-02-05 16:21    [W:4.017 / U:0.176 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site