lkml.org 
[lkml]   [2015]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] macintosh: Delete an unnecessary check before the function call "of_node_put"
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Wed, 4 Feb 2015 21:32:27 +0100

    The of_node_put() function tests whether its argument is NULL and then
    returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/macintosh/smu.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/macintosh/smu.c b/drivers/macintosh/smu.c
    index 10ae69b..d531f80 100644
    --- a/drivers/macintosh/smu.c
    +++ b/drivers/macintosh/smu.c
    @@ -557,8 +557,7 @@ int __init smu_init (void)
    return 0;

    fail_msg_node:
    - if (smu->msg_node)
    - of_node_put(smu->msg_node);
    + of_node_put(smu->msg_node);
    fail_db_node:
    of_node_put(smu->db_node);
    fail_bootmem:
    --
    2.2.2


    \
     
     \ /
      Last update: 2015-02-04 22:01    [W:4.553 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site