lkml.org 
[lkml]   [2015]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] orinoco: Delete an unnecessary check before the function call "kfree"
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Wed, 4 Feb 2015 19:53:11 +0100

    The kfree() function tests whether its argument is NULL and then
    returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/net/wireless/orinoco/main.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/wireless/orinoco/main.c b/drivers/net/wireless/orinoco/main.c
    index 38ec8d1..c410180 100644
    --- a/drivers/net/wireless/orinoco/main.c
    +++ b/drivers/net/wireless/orinoco/main.c
    @@ -2342,7 +2342,7 @@ void free_orinocodev(struct orinoco_private *priv)
    list_for_each_entry_safe(sd, sdtemp, &priv->scan_list, list) {
    list_del(&sd->list);

    - if ((sd->len > 0) && sd->buf)
    + if (sd->len > 0)
    kfree(sd->buf);
    kfree(sd);
    }
    --
    2.2.2


    \
     
     \ /
      Last update: 2015-02-04 20:21    [W:4.035 / U:0.144 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site