Messages in this thread Patch in this message | | | Date | Wed, 04 Feb 2015 17:47:27 +0100 | From | SF Markus Elfring <> | Subject | [PATCH 1/2] CW1200: Delete an unnecessary check before the function call "release_firmware" |
| |
From: Markus Elfring <elfring@users.sourceforge.net> Date: Wed, 4 Feb 2015 16:32:15 +0100
The release_firmware() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/net/wireless/cw1200/fwio.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/wireless/cw1200/fwio.c b/drivers/net/wireless/cw1200/fwio.c index 6f1b9aa..581dfde 100644 --- a/drivers/net/wireless/cw1200/fwio.c +++ b/drivers/net/wireless/cw1200/fwio.c @@ -246,8 +246,7 @@ static int cw1200_load_firmware_cw1200(struct cw1200_common *priv) error: kfree(buf); - if (firmware) - release_firmware(firmware); + release_firmware(firmware); return ret; #undef APB_WRITE -- 2.2.2
| |