lkml.org 
[lkml]   [2015]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v3] Add ARCH_MIGHT_HAVE_VGA_CONSOLE
Date
On Wednesday 04 February 2015 15:03:32 Yoshinori Sato wrote:
> @@ -2,14 +2,14 @@
> # Video configuration
> #
>
> +config ARCH_MIGHT_HAVE_VGA_CONSOLE
> + bool
> +
> menu "Console display driver support"
>
>

I just noticed one more problem: The file that you add the option to is
conditional on CONFIG_VT, and that option is user-selectable. If
VT is disabled, you will get a warning from architectures that select
the symbol.

I think you should move the statement above into drivers/video/Kconfig,
outside of the 'if VT'.

Arnd


\
 
 \ /
  Last update: 2015-02-04 08:41    [W:3.086 / U:0.804 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site