Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH v3] Add ARCH_MIGHT_HAVE_VGA_CONSOLE | Date | Wed, 04 Feb 2015 08:37:16 +0100 |
| |
On Wednesday 04 February 2015 15:03:32 Yoshinori Sato wrote: > @@ -2,14 +2,14 @@ > # Video configuration > # > > +config ARCH_MIGHT_HAVE_VGA_CONSOLE > + bool > + > menu "Console display driver support" > >
I just noticed one more problem: The file that you add the option to is conditional on CONFIG_VT, and that option is user-selectable. If VT is disabled, you will get a warning from architectures that select the symbol.
I think you should move the statement above into drivers/video/Kconfig, outside of the 'if VT'.
Arnd
| |