Messages in this thread | | | From | OGAWA Hirofumi <> | Subject | Re: [PATCH v3 1/1] ioctl-fat.2: new manpage for the ioctl fat API | Date | Tue, 03 Feb 2015 17:51:23 +0900 |
| |
"Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com> writes:
> Hello Heinrich and Ogawa,
Hi,
> On 23 January 2015 at 20:54, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote: >> The ioctl(2) system call may be used to retrieve information about >> the fat file system and to set file attributes. >> >> This new manpage describes the details. > > @Ogawa, as the FAT maintainer, might you be willing to review this page?
for (;;) {
/* * Read next directory entry. */ ret = ioctl( fd, VFAT_IOCTL_READDIR_BOTH, entry);
/* * If an error occurs, the return value is -1. * If d_reclen is zero, the end of the directory * list has been reached. */ if (ret == -1 || entry[0].d_reclen == 0) break;
Quick reviewed, and looks good. However, entry[0].d_reclen == 0 works as backward compatibility though. The example might be good to use usual way of getdents().
I.e., "ret" means -1 == error 0 == EOD 0 > how many bytes read
Thanks. -- OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
| |