Messages in this thread | | | Date | Tue, 3 Feb 2015 12:00:09 -0800 | From | Dmitry Torokhov <> | Subject | Re: [PATCH v3 3/4] pinctrl: cygnus: add initial IOMUX driver support |
| |
On Tue, Feb 03, 2015 at 11:29:36AM -0800, Ray Jui wrote: > On 2/3/2015 9:40 AM, Dmitry Torokhov wrote: > > On Mon, Feb 02, 2015 at 06:01:33PM -0800, Ray Jui wrote: > >> + > >> +/* > >> + * List of pins in Cygnus > >> + */ > >> +static struct cygnus_pin cygnus_pins[] = { > > > > const? > > > I cannot make it const here, since the address of "gpio_mux" is later > passed to pinctrl_pin_desc's private data: > > pins[i].drv_data = &cygnus_pins[i].gpio_mux;
The pinctrl code says:
"@drv_data: driver-defined per-pin data. pinctrl core does not touch this"
so we could theoretically cast away the constness and restore it when we access drv_data in pin control methods, but I won't insist. I am not sure which way looks nicer.
Thanks.
-- Dmitry
| |