lkml.org 
[lkml]   [2015]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: mips: Re-introduce copy_user_page
On 01/30/2015 09:23 PM, Guenter Roeck wrote:
> Commit bcd022801ee5 ("MIPS: Fix COW D-cache aliasing on fork") replaced
> the inline function copy_user_page for mips with an external reference,
> but neglected to introduce the actual non-inline function. Restore it.
>
> Fixes: bcd022801ee5 ("MIPS: Fix COW D-cache aliasing on fork")
> Fixes: 4927b7d77c00 ("dax,ext2: replace the XIP page fault handler with the DAX page fault handler")
> Cc: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
> Cc: Matthew Wilcox <matthew.r.wilcox@intel.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>

Why do you use copy_user_page?
It doesn't work properly in HIGHMEM environment and it is excluded from
MIPS because of that, I believe.

You should use copy_user_highpage() for user pages.

- Leonid.



\
 
 \ /
  Last update: 2015-02-03 20:01    [W:0.049 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site