lkml.org 
[lkml]   [2015]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 1/2] [media] DVB: Delete an unnecessary check before the function call "dvb_unregister_device"
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Tue, 3 Feb 2015 16:01:40 +0100

    The dvb_unregister_device() function tests whether its argument is NULL
    and then returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/media/dvb-core/dvb_ca_en50221.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/media/dvb-core/dvb_ca_en50221.c b/drivers/media/dvb-core/dvb_ca_en50221.c
    index 0aac309..b999689 100644
    --- a/drivers/media/dvb-core/dvb_ca_en50221.c
    +++ b/drivers/media/dvb-core/dvb_ca_en50221.c
    @@ -1726,8 +1726,7 @@ int dvb_ca_en50221_init(struct dvb_adapter *dvb_adapter,

    error:
    if (ca != NULL) {
    - if (ca->dvbdev != NULL)
    - dvb_unregister_device(ca->dvbdev);
    + dvb_unregister_device(ca->dvbdev);
    kfree(ca->slot_info);
    kfree(ca);
    }
    --
    2.2.2


    \
     
     \ /
      Last update: 2015-02-03 17:41    [W:4.018 / U:0.156 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site