lkml.org 
[lkml]   [2015]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] [media] sp2: Delete an unnecessary check before the function call "kfree"
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Tue, 3 Feb 2015 15:05:26 +0100

    The kfree() function tests whether its argument is NULL and then
    returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/media/dvb-frontends/sp2.c | 5 +----
    1 file changed, 1 insertion(+), 4 deletions(-)

    diff --git a/drivers/media/dvb-frontends/sp2.c b/drivers/media/dvb-frontends/sp2.c
    index cc1ef96..8fd4276 100644
    --- a/drivers/media/dvb-frontends/sp2.c
    +++ b/drivers/media/dvb-frontends/sp2.c
    @@ -413,11 +413,8 @@ static int sp2_remove(struct i2c_client *client)
    struct sp2 *s = i2c_get_clientdata(client);

    dev_dbg(&client->dev, "\n");
    -
    sp2_exit(client);
    - if (s != NULL)
    - kfree(s);
    -
    + kfree(s);
    return 0;
    }

    --
    2.2.2


    \
     
     \ /
      Last update: 2015-02-03 15:21    [W:4.029 / U:0.316 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site