lkml.org 
[lkml]   [2015]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] pwm: Delete an unnecessary check before the function call "of_node_put"
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Tue, 3 Feb 2015 11:54:28 +0100

    The of_node_put() function tests whether its argument is NULL and then
    returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/pwm/core.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c
    index 966497d..810aef3 100644
    --- a/drivers/pwm/core.c
    +++ b/drivers/pwm/core.c
    @@ -192,7 +192,7 @@ static void of_pwmchip_add(struct pwm_chip *chip)

    static void of_pwmchip_remove(struct pwm_chip *chip)
    {
    - if (chip->dev && chip->dev->of_node)
    + if (chip->dev)
    of_node_put(chip->dev->of_node);
    }

    --
    2.2.2


    \
     
     \ /
      Last update: 2015-02-03 12:41    [W:6.534 / U:0.104 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site