Messages in this thread | | | Date | Tue, 03 Feb 2015 11:36:56 +0200 | From | Stanimir Varbanov <> | Subject | Re: [PATCH V2 1/2] spmi: remove wakeup command before slave probe |
| |
On 01/31/2015 02:46 AM, Gilad Avidov wrote: > According to spmi spec a slave powers up into startup state and then > transitions into active state. Thus, the wakeup command is not required > before calling the slave's probe. The wakeup command is only needed for > slaves that are in sleep state after receiving the sleep command. > > This is a bug since spmi master controllers, such as spmi-pmic-arb, > which have no support for wakeup command return an error on that > command and thus fail before reaching a slave driver probe. > > Cc: galak@codeaurora.org > Acked-by: Sagar Dharia <sdharia@codeaurora.org> > Signed-off-by: Gilad Avidov <gavidov@codeaurora.org> > --- > drivers/spmi/spmi.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/drivers/spmi/spmi.c b/drivers/spmi/spmi.c > index 1d92f51..9ff7454 100644 > --- a/drivers/spmi/spmi.c > +++ b/drivers/spmi/spmi.c > @@ -1,4 +1,4 @@ > -/* Copyright (c) 2012-2013, The Linux Foundation. All rights reserved. > +/* Copyright (c) 2012-2015, The Linux Foundation. All rights reserved.
run chackpatch please.
<snip>
-- regards, Stan
| |