Messages in this thread | | | Date | Fri, 27 Feb 2015 16:53:16 -0600 (CST) | From | Christoph Lameter <> | Subject | Re: [patch v2 1/3] mm: remove GFP_THISNODE |
| |
On Fri, 27 Feb 2015, David Rientjes wrote:
> +/* > + * Construct gfp mask to allocate from a specific node but do not invoke reclaim > + * or warn about failures. > + */
We should be triggering reclaim from slab allocations. Why would we not do this?
Otherwise we will be going uselessly off node for slab allocations.
> +static inline gfp_t gfp_exact_node(gfp_t flags) > +{ > + return (flags | __GFP_THISNODE | __GFP_NOWARN) & ~__GFP_WAIT; > +} > #endif
Reclaim needs to be triggered. In particular zone reclaim was made to be triggered from slab allocations to create more room if needed.
| |