This message generated a parse failure. Raw output follows here. Please use 'back' to navigate. From devnull@lkml.org Wed Apr 24 14:25:55 2024 >From spaans Fri Feb 27 04:02:47 2015 Received: from pop.ziggo.nl [212.54.42.19] by squeeze.vs19.net with POP3 (fetchmail-6.3.21) for (single-drop); Fri, 27 Feb 2015 04:02:47 +0100 (CET) Received: from md2.tb.mail.iss.local ([212.54.42.145]) by mc5.tb.mail.iss.local (Dovecot) with LMTP id BLEOEurd71SYJQAAh0Kp1A for ; Fri, 27 Feb 2015 04:01:44 +0100 Received: from mx18.tb.mail.iss.as9143.net ([212.54.42.145]) by md2.tb.mail.iss.local (Dovecot) with LMTP id GmNeO6jrgFQzZAAAH7GgQA ; Fri, 27 Feb 2015 04:02:52 +0100 Received: from vger.kernel.org ([209.132.180.67]) by mx18.tb.mail.iss.as9143.net with esmtp (Exim 4.82) (envelope-from ) id 1YRBBP-0006Wj-DW for bmw12-lkml@ziggo.nl; Fri, 27 Feb 2015 04:01:44 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754035AbbB0DBd (ORCPT ); Thu, 26 Feb 2015 22:01:33 -0500 Received: from mail-ie0-f172.google.com ([209.85.223.172]:43752 "EHLO mail-ie0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752001AbbB0DBc (ORCPT ); Thu, 26 Feb 2015 22:01:32 -0500 Received: by iebtr6 with SMTP id tr6so24834410ieb.10 for ; Thu, 26 Feb 2015 19:01:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version:content-type:content-id; bh=sE3GVxAeYTJAwsb93TrIywngiLQaxyjs3/LvwcLOYx8=; X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version:content-type:content-id; bh=sE3GVxAeYTJAwsb93TrIywngiLQaxy X-Gm-Message-State: ALoCoQmLg4srvFlq9ToaSVLXjKKhY3dyETO+nKx0ZTX6DcxR8Ig5DzC+5dgntIOvx5JCGJKa5Pa7 X-Received: by 10.107.128.219 with SMTP id k88mr15575559ioi.27.1425006091267; Thu, 26 Feb 2015 19:01:31 -0800 (PST) Received: from [2620:0:1008:1101:512e:f996:8871:54f4] ([2620:0:1008:1101:512e:f996:8871:54f4]) by mx.google.com with ESMTPSA id n17sm714310igi.2.2015.02.26.19.01.29 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 26 Feb 2015 19:01: Date: Thu, 26 Feb 2015 19:01:28 -0800 (PST) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: =?UTF-8?Q?Arve_Hj=C3=B8nnev=C3=A5g?= Cc: Amit Pundir , LKML , a.ryabinin@samsung.com, dvyukov@google.com, kcc@google.com, dmitryc@google.com, adech.fo@gmail.com, tetra2005@gmail.com, koct9i@gmail.com, sasha.levin@oracle.com, cl@linux.com, ia Subject: Re: Regression in v4.0.0-rc1 with Android Binder In-Reply-To: Message-Id: References: User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) Mime-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="531381512-31614197-1425005989=:24302" Content-ID: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-Id: X-Mailing-List: linux-kernel@vger.kernel.org X-Ziggo-spamsetting: Instelling=Gemiddeld Scorelimiet=14 X-Ziggo-spambar: / X-Ziggo-spamscore: -0.4 X-Ziggo-spamreport: BAYES_00=-1.9,CM_SPACED_DATE=0.5,HEADER_FROM_DIFFERENT_DOMAINS=0.001,L_TAB_IN_FROM=2,RCVD_IN_JMF_W=-1,RCVD_IN_MSPIKE_H3=-0.01,RCVD_IN_MSPIKE_WL=-0.01,T_RP_MATCHES_RCVD=-0.01,T_TVD_MIME_EPI=0.01 X-Ziggo-Spam-Status: No X-Spam-Status: No X-Spam-Flag: No This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --531381512-31614197-1425005989=:24302 Content-Type: TEXT/PLAIN; CHARSET=UTF-8 Content-Transfer-Encoding: 8BIT Content-ID: On Thu, 26 Feb 2015, Arve Hjønnevåg wrote: > > ----------8<---------- > > --- a/drivers/android/binder.c > > +++ b/drivers/android/binder.c > > @@ -601,6 +601,7 @@ static int binder_update_page_range(struct > > binder_proc *proc, int allocate, > > goto err_alloc_page_failed; > > } > > tmp_area.addr = page_addr; > > + tmp_area.flags &= ~VM_NO_GUARD; > > This variable is not initialized, so I would expect this to add a > warning. Setting it to VM_NO_GUARD and removing, " + PAGE_SIZE /* > guard page? */" fromt he next line would be better. However, the "new" > map_kernel_range_noflush api seems like a better api to use for this, > since it removes the need to create a dummy vm_struct at all. > Yeah, this is what you want to do and it's a bug in commit 71394fe50146 ("mm: vmalloc: add flag preventing guard hole allocation") that started to look at tmp_area.size without fixing up any of the callers when tmp_area.addr and tmp_area.size were only important in the past. It shouldn't take much work to make this use map_kernel_range_noflush(). > > tmp_area.size = PAGE_SIZE + PAGE_SIZE /* guard page? */; > > ret = map_vm_area(&tmp_area, PAGE_KERNEL, page); > > if (ret) { > > ---------->8---------- --531381512-31614197-1425005989=:24302-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/