lkml.org 
[lkml]   [2015]   [Feb]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v2] usb: isp1760: add peripheral/device controller chip id
    Date
    Hi Sudeep,

    Thank you for the patch.

    On Thursday 26 February 2015 11:47:57 Sudeep Holla wrote:
    > As per the SAF1761 data sheet[0], the DcChipID register represents
    > the hardware version number (0001h) and the chip ID (1582h) for the
    > Peripheral Controller.
    >
    > However as per the ISP1761 data sheet[1], the DcChipID register
    > represents the hardware version number (0015h) and the chip ID (8210h)
    > for the Peripheral Controller.
    >
    > This patch adds support for both the chip ID values.
    >
    > [0] http://www.nxp.com/documents/data_sheet/SAF1761.pdf
    > [1] http://pdf.datasheetcatalog.com/datasheets2/74/742102_1.pdf
    >
    > Cc: Felipe Balbi <balbi@ti.com>
    > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
    > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>

    Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

    > ---
    > drivers/usb/isp1760/isp1760-udc.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > Changes v1->v2:
    > - Updated to support both chip IDs: 0x00011582 and 0x00158210 instead of
    > just 0x00158210 as suggested by Laurent
    >
    > diff --git a/drivers/usb/isp1760/isp1760-udc.c
    > b/drivers/usb/isp1760/isp1760-udc.c index 9612d7990565..6d618b3fab07 100644
    > --- a/drivers/usb/isp1760/isp1760-udc.c
    > +++ b/drivers/usb/isp1760/isp1760-udc.c
    > @@ -1411,7 +1411,7 @@ static int isp1760_udc_init(struct isp1760_udc *udc)
    > return -ENODEV;
    > }
    >
    > - if (chipid != 0x00011582) {
    > + if (chipid != 0x00011582 && chipid != 0x00158210) {
    > dev_err(udc->isp->dev, "udc: invalid chip ID 0x%08x\n", chipid);
    > return -ENODEV;
    > }

    --
    Regards,

    Laurent Pinchart



    \
     
     \ /
      Last update: 2015-02-26 20:01    [W:4.100 / U:0.140 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site