Messages in this thread | | | Date | Thu, 26 Feb 2015 15:25:26 +0100 | From | Alexander Graf <> | Subject | Re: [PATCH v2 1/1] drivers/bus: fsl-mc object allocator driver |
| |
On 24.02.15 23:50, J. German Rivera wrote: > The fsl-mc object allocator driver manages "allocatable" fsl-mc > objects such as DPBPs, DPMCPs and DPCONs. It provides services to
I'd recommend to explain what these abbreviations mean. It's ridiculously hard to remember what they are about. So please put their full name at least into the patch description and into the headers of their respective handling files.
Also, can we maybe split the patches into the minimal set required to get one driver working? I hate to see lots of functions land in upstream that are never called from anywhere. At the end of the day, I care about vertical coverage, not horizontal. All of your patches so far are horizontal.
So please pick one driver, choose the subset required to make bus enumeration, DPRC handling and the few objects required for that one driver work and then let's try to push it upstream.
Once that's done we can easily extend the interface incrementally with every other new driver from that point on.
Alex
| |