Messages in this thread | | | Date | Thu, 26 Feb 2015 13:27:30 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH v2] PCI/AER: Avoid info leak in __print_tlp_header |
| |
On Thu, Feb 26, 2015 at 09:55:03AM +0100, Rasmus Villemoes wrote: > Commit fab4c256a58b ("PCI/AER: Add a TLP header print helper") > introduced the helper function __print_tlp_header, but contrary to the > intention, the behaviour did change: Since we're taking the address of > the parameter t, the first 4 or 8 bytes printed will be the value of > the pointer t itself, and the remaining 12 or 8 bytes will be > who-knows-what (something from the stack). > > We want to show the values of the four members of the struct > aer_header_log_regs; that can be done without ugly and error-prone > casts. On little-endian this should produce the same output as > originally intended, and since no-one has complained about getting > garbage output so far, I think big-endian should be ok too. > > Fixes: fab4c256a58b ("PCI/AER: Add a TLP header print helper") > Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: <stable@vger.kernel.org>
Acked-by: Borislav Petkov <bp@suse.de>
-- Regards/Gruss, Boris.
ECO tip #101: Trim your mails when you reply. --
| |