lkml.org 
[lkml]   [2015]   [Feb]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Question about Old Fix Me comment in mempool.c


On Tue, 16 Dec 2014, nick wrote:

> Greetings Andrew and other maintainers,
> I am wondering why the below comment is even in mempool.c and this has not been changed to a call to io_schedule as the kernel version is stupidly old and this should be fixed by now and the issues with DM would have been removed by now.
> /*
> * FIXME: this should be io_schedule(). The timeout is there as a
> * workaround for some DM problems in 2.6.18.
> */
>
> Sorry for the stupid question but I like to double check with the maintainers before I sent in a patch for things like this to see if I am missing anything:).
>
> Thanks for Your Time,
> Nick

There are still some bugs with respect to this (and they will probably
never be removed all) - for example this bug which wasn't fixed yet
http://www.redhat.com/archives/dm-devel/2014-May/msg00089.html .

So, you should not remove it.

Mikulas


\
 
 \ /
  Last update: 2015-02-25 22:01    [W:0.027 / U:0.784 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site