lkml.org 
[lkml]   [2015]   [Feb]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [patch 2/2] rocker: silence shift wrapping warning
From
On Wed, Feb 25, 2015 at 5:36 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> "val" is declared as a u64 so static checkers complain that this shift
> can wrap. I don't have the hardware but probably it's doesn't have over
> 31 ports. Still we may as well silence the warning even if it's not a
> real bug.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/net/ethernet/rocker/rocker.c b/drivers/net/ethernet/rocker/rocker.c
> index 713a13c..9fb6948 100644
> --- a/drivers/net/ethernet/rocker/rocker.c
> +++ b/drivers/net/ethernet/rocker/rocker.c
> @@ -1257,9 +1257,9 @@ static void rocker_port_set_enable(struct rocker_port *rocker_port, bool enable)
> u64 val = rocker_read64(rocker_port->rocker, PORT_PHYS_ENABLE);
>
> if (enable)
> - val |= 1 << rocker_port->lport;
> + val |= 1ULL << rocker_port->lport;
> else
> - val &= ~(1 << rocker_port->lport);
> + val &= ~(1ULL << rocker_port->lport);
> rocker_write64(rocker_port->rocker, PORT_PHYS_ENABLE, val);
> }
>

Acked-by: Scott Feldman <sfeldma@gmail.com>


\
 
 \ /
  Last update: 2015-02-25 15:01    [W:0.096 / U:0.224 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site