Messages in this thread | | | From | Andy Lutomirski <> | Date | Tue, 24 Feb 2015 16:03:14 -0800 | Subject | Re: [PATCH 1/7] x86: ia32entry.S: use more understandable constant |
| |
On Tue, Feb 24, 2015 at 4:00 PM, Denys Vlasenko <dvlasenk@redhat.com> wrote: > The last instance of "mysterious" SS+8 constant is replaced by SIZEOF_PTREGS.
Applied and checked by reading the macro definition :)
> > Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com> > CC: Linus Torvalds <torvalds@linux-foundation.org> > CC: Steven Rostedt <rostedt@goodmis.org> > CC: Ingo Molnar <mingo@kernel.org> > CC: Borislav Petkov <bp@alien8.de> > CC: "H. Peter Anvin" <hpa@zytor.com> > CC: Andy Lutomirski <luto@amacapital.net> > CC: Oleg Nesterov <oleg@redhat.com> > CC: Frederic Weisbecker <fweisbec@gmail.com> > CC: Alexei Starovoitov <ast@plumgrid.com> > CC: Will Drewry <wad@chromium.org> > CC: Kees Cook <keescook@chromium.org> > CC: x86@kernel.org > CC: linux-kernel@vger.kernel.org > --- > arch/x86/ia32/ia32entry.S | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/ia32/ia32entry.S b/arch/x86/ia32/ia32entry.S > index 6dcd372..ed97463 100644 > --- a/arch/x86/ia32/ia32entry.S > +++ b/arch/x86/ia32/ia32entry.S > @@ -536,7 +536,7 @@ ia32_ptregs_common: > CFI_ENDPROC > CFI_STARTPROC32 simple > CFI_SIGNAL_FRAME > - CFI_DEF_CFA rsp,SS+8 > + CFI_DEF_CFA rsp,SIZEOF_PTREGS > CFI_REL_OFFSET rax,RAX > CFI_REL_OFFSET rcx,RCX > CFI_REL_OFFSET rdx,RDX > -- > 1.8.1.4 >
-- Andy Lutomirski AMA Capital Management, LLC
| |