Messages in this thread | | | Date | Tue, 24 Feb 2015 13:52:22 -0800 | From | "H. Peter Anvin" <> | Subject | Re: [tip:x86/asm] x86/asm: Add support for the pcommit instruction |
| |
On 02/24/2015 01:48 PM, Ross Zwisler wrote: > On Tue, 2015-02-24 at 13:41 -0800, H. Peter Anvin wrote: >> On 02/24/2015 01:40 PM, H. Peter Anvin wrote: >>> On 02/24/2015 01:30 AM, Borislav Petkov wrote: >>>> On Mon, Feb 23, 2015 at 03:14:01PM -0800, H. Peter Anvin wrote: >>>>> That may cause the same line to be flushed twice. I would suggest, >>>>> instead, also removing the arithmetic on void *: >>>> >>>> Btw, should we hold down all those suggested usages somewhere in >>>> Documentation/x86/ as commit messages are generally harder to find? >>>> >>> >>> Yes, and commit messages can't be corrected after the fact. >>> >> >> Either that, or perhaps even better in kerneldoc comments in the source >> itself. > > Either sounds like a good idea to me. :) Let me know which you'd prefer > and I'll get something written up. >
Kerneldoc would be better, as it is more likely to be maintained in proximity for the source.
-hpa
| |