Messages in this thread Patch in this message | | | From | Ameen Ali <> | Subject | [PATCH] dcssblk.c : Array index 'i' is used before limits check. | Date | Tue, 24 Feb 2015 18:41:50 +0200 |
| |
avoid out-of-bounds-read by checking count before indexing.
Signed-off-by : Ameen Ali <Ameenali023@gmail.com> --- drivers/s390/block/dcssblk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/s390/block/dcssblk.c b/drivers/s390/block/dcssblk.c index 96128cb..da21281 100644 --- a/drivers/s390/block/dcssblk.c +++ b/drivers/s390/block/dcssblk.c @@ -547,7 +547,7 @@ dcssblk_add_store(struct device *dev, struct device_attribute *attr, const char * parse input */ num_of_segments = 0; - for (i = 0; ((buf[i] != '\0') && (buf[i] != '\n') && i < count); i++) { + for (i = 0; (i < count && (buf[i] != '\0') && (buf[i] != '\n')); i++) { for (j = i; (buf[j] != ':') && (buf[j] != '\0') && (buf[j] != '\n') && -- 2.1.0
| |